Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 4 active-selection-* tests #24710

Closed
wants to merge 1 commit into from
Closed

Added 4 active-selection-* tests #24710

wants to merge 1 commit into from

Conversation

TalbotG
Copy link
Contributor

@TalbotG TalbotG commented Jul 23, 2020

active-selection-021.html
reference/active-selection-021-ref.html

active-selection-024.html
reference/active-selection-024-ref.html

active-selection-031.html
reference/active-selection-031-ref.html

active-selection-045.html

support/100x100-red.png

This is a followup to
#20931

@TalbotG TalbotG assigned frivoal and fantasai and unassigned plinss Jul 23, 2020
@TalbotG
Copy link
Contributor Author

TalbotG commented Jul 23, 2020

:( I am going to try again with 2 smaller PRs.

This was referenced Jul 23, 2020
Merged
Merged
@TalbotG TalbotG removed the request for review from plinss July 23, 2020 16:48
@TalbotG TalbotG assigned TalbotG and unassigned frivoal and fantasai Jul 23, 2020
@TalbotG
Copy link
Contributor Author

TalbotG commented Jul 23, 2020 •
edited
Loading

active-selection-045.html is most likely the test
that makes the check wpt-chrome-dev-stability fails.
Now, the only declaration that could affect Chrome is
font-size: 300px .
I am carefully checking again this in
#24723
and if the check wpt-chrome-dev-stability fails
again over there, then I will try again with
font-size: 150px .

When I try active-selection-045.html with
Chromium 86.0.4211.0 (dev build)
with a font size of 300px,
I see/get no problem at all.

@TalbotG TalbotG mentioned this pull request Jul 24, 2020
Closed
@TalbotG
Copy link
Contributor Author

TalbotG commented Jul 24, 2020

I must close this PR and delete this branch now that
#24713
#24714
have merged.

@TalbotG TalbotG closed this Jul 24, 2020
@TalbotG TalbotG deleted the CSS4Pseudo-GT-PR27 branch July 24, 2020 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fantasai fantasai fantasai approved these changes

@frivoal frivoal Awaiting requested review from frivoal

Assignees

@TalbotG TalbotG

Labels
css-pseudo
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TalbotG @fantasai @frivoal @plinss @wpt-pr-bot